Add buzzer feedback on GPS toggle #5090
Conversation
Add playbeep to triple press GPS to provide feedback for screenless devices
fix some readability
|
|
|
|
|
This is a great idea, thank you! |
|
@fifieldt Thank you! After playing around with it, it probably should have some audio cue for on vs off, but I am not a musician. |
|
Maybe since the disable sequence is a triple push, the associated buzzer should be a triple sound? |
|
Triple click enables and disables. I will play around and see |
One beep for GPS enable and the same beep for disable made it impossible to know which is which so now it has distinct different sounds.
|
triple low sound after disabling, triple high sound after enabling? |
|
The most recent commit sounds like this: https://youtu.be/VHLxfraEB0k?si=R2N3lvpfyCn2dF4E |
|
Don't merge yet the noise is backwards according to what the app reports |
|
Thanks so much for providing the video - helps a lot as I haven't time to flash and test. I think the sound is good enough to ship - we can always change later if needed :) @Technologyman00 - are you familiar with the trunk linting/formatting tool? We use it to keep out files formatted the same. It looks like it needs to be run on the files from this patch. Could you do that? If not , let us know and someone will help. Other than that, good to go. |
|
We should also make sure this works OK on devices that don't have a buzzer. |
The sounds were associated with the wrong function
|
Ok I just tested it on my T114 V1 and it works. I don't have a different one to test. |
|
OK, looks like buzzer.h is included by main and not guarded by PIN_BUZZER so will have no impact on devices without buzzers |
|
Someone else can do it or tell me why its been stuck doing this for the past while |
* Coerce minimum telemetry interval of 30 minutes on defaults and make new default interval one hour (meshtastic#5086) * Coerce minimum telemetry interval of 30 minutes on defaults and make new default interval one hour * Smaller log messages * Add buzzer feedback on GPS toggle (meshtastic#5090) Triple Press on buttons toggles GPS enable/disable. This enhancement plays a triple-beep so that users of devices with buzzers can get audible feedback about whether they have turned the GPS off or on. This is especially valuable for screenless devices such as the T1000E where it may not be immediately obvious the GPS has been disabled. --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Technologyman00 <[email protected]>
|
@Technologyman00 re: #5090 (comment) Trunk doesn't work on windows for some reason. There's workarounds, either making it work in Windows by placing the files manually or running it in WSL, but I found the quickest way for a casual update was gitpod. YMMV. Love this idea and implementation, btw. I have lots of screenless GPS devices, and this is really cool. |
* Coerce minimum telemetry interval of 30 minutes on defaults and make new default interval one hour (meshtastic#5086) * Coerce minimum telemetry interval of 30 minutes on defaults and make new default interval one hour * Smaller log messages * Add buzzer feedback on GPS toggle (meshtastic#5090) Triple Press on buttons toggles GPS enable/disable. This enhancement plays a triple-beep so that users of devices with buzzers can get audible feedback about whether they have turned the GPS off or on. This is especially valuable for screenless devices such as the T1000E where it may not be immediately obvious the GPS has been disabled. --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Technologyman00 <[email protected]>
Triple Press on buttons toggles GPS enable/disable. This enhancement plays a triple-beep so that users of devices with buzzers can get audible feedback about whether they have turned the GPS off or on. This is especially valuable for screenless devices such as the T1000E where it may not be immediately obvious the GPS has been disabled.
Addresses #5089. Screen-less devices don't have any feedback for a triple click of the button so it maybe difficult to ensure the GPS was disabled